GODRIVER-3098 Sync SDAM spec tests at 348d2f39. #1986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
the
review-priority-low
API Change ReportNo changes found! |
matthewdale
force-pushed
the
godriver3098-sync-tests
branch
5 times, most recently
from
f0aa407 to
e0de429
Compare
This was referenced Mar 14, 2025
matthewdale
force-pushed
the
godriver3098-sync-tests
branch
from
e0de429 to
9d0de54
Compare
matthewdale
force-pushed
the
godriver3098-sync-tests
branch
from
9d0de54 to
8c8559b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes SDAM spec tests to commit 348d2f39 in preparation for dropping support for MongoDB 3.6 and adjusts test skip logic accordingly. Key changes include:
- Adding a new skip tests file (internal/spectest/skip.go) and updating skip logic in unified spec tests.
- Removing redundant, hardcoded skipped test mappings in unified_spec_runner.
- Updating YAML test files to revise maxWireVersion values from 6 to 21 and minor test naming adjustments.
Reviewed Changes
Copilot reviewed 222 out of 222 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/spectest/skip.go | New file providing centralized skip test configuration. |
| internal/integration/unified_spec_test.go | Updated to call the new CheckSkip function instead of using legacy mappings. |
| internal/integration/unified/unified_spec_runner.go | Removed redundant skippedTests mapping in favor of centralized handling. |
| testdata/server-discovery-and-monitoring/*.yml | Updated maxWireVersion from 6 to 21 to align with spec changes. |
| internal/serverselector/server_selector_test.go | Removed manual filename trimming to simplify test naming. |
| bson/bson_corpus_spec_test.go | Adjusted test naming for consistency and adherence to Go style. |
qingyang-hu
previously approved these changes
Mar 17, 2025
matthewdale
dismissed
qingyang-hu’s stale review
The merge-base changed after approval.
matthewdale
force-pushed
the
godriver3098-sync-tests
branch
from
8c8559b to
e48a5e8
Compare
qingyang-hu
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3098
Summary
Background & Motivation
Part of a stack of changes that must be reviewed in order: